[webkit-reviews] review granted: [Bug 62199] new-run-webkit-tests: support --repeat-each feature from old-run-webkit-tests : [Attachment 113828] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 7 11:45:32 PST 2011


Dirk Pranke <dpranke at chromium.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 62199: new-run-webkit-tests: support --repeat-each feature from
old-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=62199

Attachment 113828: Patch
https://bugs.webkit.org/attachment.cgi?id=113828&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=113828&action=review



> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:507
> +	   # FIXME: It's unclear how --repeat-each and --iterations should
interact with chunks?

I'd probably just make them mutually exclusive for now. chunks are only used on
the bots and aren't likely to need either of those flags.


Change looks fine. I'm cq-'ing it in case you want to make the flags mutually
exclusive as I suggest (and possibly add some tests enforcing that). I don't
feel strongly about it, however, so you can leave things as-is or just update
the fixme to say that you should make them mutually exclusive at some point.


More information about the webkit-reviews mailing list