[webkit-reviews] review denied: [Bug 71710] Web Inspector: Suggest box should be open immediately if forced by Ctrl+Space. : [Attachment 113896] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Nov 7 11:23:27 PST 2011
Pavel Feldman <pfeldman at chromium.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 71710: Web Inspector: Suggest box should be open immediately if forced by
Ctrl+Space.
https://bugs.webkit.org/show_bug.cgi?id=71710
Attachment 113896: Patch
https://bugs.webkit.org/attachment.cgi?id=113896&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=113896&action=review
> Source/WebCore/inspector/front-end/TextPrompt.js:297
> + if (this._completeImmediately) {
There is no need for the additional timer. setTimeout(0) is likely to dispatch
before the subsequent keyboard event.
More information about the webkit-reviews
mailing list