[webkit-reviews] review granted: [Bug 71458] [chromium] MediaStream API: Add WebMediaStreamRegistry : [Attachment 113640] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 7 09:32:07 PST 2011


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Tommy
Widenflycht <tommyw at google.com>'s request for review:
Bug 71458: [chromium] MediaStream API: Add WebMediaStreamRegistry
https://bugs.webkit.org/show_bug.cgi?id=71458

Attachment 113640: Patch
https://bugs.webkit.org/attachment.cgi?id=113640&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=113640&action=review


> Source/WebKit/chromium/src/WebMediaStreamRegistry.cpp:44
> +    return
WebMediaStreamDescriptor(MediaStreamRegistry::registry().lookupMediaStreamDescr
iptor(kurl.string()));

nit: it is perhaps a bit more conventional in webkit code to just use
KURL(url).string() instead of creating the named temporary variable.


More information about the webkit-reviews mailing list