[webkit-reviews] review granted: [Bug 71485] [Chromium] Rename WebView::scalePage to WebView::setPageScaleFactor to match WebCore : [Attachment 113776] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 7 09:22:54 PST 2011


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Fady Samuel
<fsamuel at chromium.org>'s request for review:
Bug 71485: [Chromium] Rename WebView::scalePage to WebView::setPageScaleFactor
to match WebCore
https://bugs.webkit.org/show_bug.cgi?id=71485

Attachment 113776: Patch
https://bugs.webkit.org/attachment.cgi?id=113776&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=113776&action=review


> Source/WebKit/chromium/public/WebView.h:220
> +    virtual void setPageScaleFactor(float scaleFactor, WebPoint origin) = 0;


nit: while you are at it, the WebPoint parameter should probably be passed as
"const WebPoint&"


More information about the webkit-reviews mailing list