[webkit-reviews] review requested: [Bug 69411] [WK2] [GTK] Implement a MouseDown/MouseUp/MouseMoveTo/MouseScrollBy/LeapForward functions for WebKit2 EventSender : [Attachment 113870] Patch

[bugzilla-daemon at webkit.org]

Sergio Villar Senin <svillar at igalia.com> has asked  for review:
Bug 69411: [WK2] [GTK] Implement a
MouseDown/MouseUp/MouseMoveTo/MouseScrollBy/LeapForward functions for WebKit2
EventSender
https://bugs.webkit.org/show_bug.cgi?id=69411

Attachment 113870: Patch
https://bugs.webkit.org/attachment.cgi?id=113870&action=review

------- Additional Comments from Sergio Villar Senin <svillar at igalia.com>
I've been working on this since the first patch and I came up with a very
similar patch to the one posted here by Kaustubh Atrawalkar. There are a couple
of things that are better addressed in my patch IMHO.

- we should use the private attributes of the EventSender instead of defining a
set of static variables
- the PLATFORM() stuff should not be removed but PLATFORM(GTK) should be added
- the Skipped file should have links to the existent bugs. Also moved tests
with no results to their proper section.
- some function names should be more explanatory
- There was no ChangeLog entry for Tools

Of course I kept the authorship from Kaustubh Atrawalkar in my patch.