[webkit-reviews] review granted: [Bug 71627] Web Inspector: introduce UserAgent override setting. : [Attachment 113787] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 71627: Web Inspector: introduce UserAgent override setting.
https://bugs.webkit.org/show_bug.cgi?id=71627

Attachment 113787: Patch
https://bugs.webkit.org/attachment.cgi?id=113787&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=113787&action=review


> Source/WebCore/inspector/front-end/SettingsScreen.js:64
> +    p.appendChild(this._createUserActionControl());

_createUserA gent Control

> Source/WebCore/inspector/front-end/SettingsScreen.js:240
> +	       ["Internet Explorer 9", "Mozilla/5.0 (compatible; MSIE 9.0;
Windows NT 6.1; Trident/5.0"],

Let's sort these options alphabetically.

> Source/WebCore/inspector/front-end/SettingsScreen.js:247
> +	       ["Firefox 4 \u2014 Mac", "Mozilla/5.0 (Macintosh; Intel Mac OS X
10.6; rv:2.0.1) Gecko/20100101 Firefox/4.0.1"],

I'd suggest adding FF3 as well.