[webkit-reviews] review granted: [Bug 71644] Change ColorChooser from singleton to ordinary object : [Attachment 113825] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 71644: Change ColorChooser from singleton to ordinary object
https://bugs.webkit.org/show_bug.cgi?id=71644

Attachment 113825: Patch
https://bugs.webkit.org/attachment.cgi?id=113825&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=113825&action=review


> Source/WebCore/ChangeLog:30
> +	   * platform/ColorChooser.cpp: Styled after FileChooser

What does this mean?

> Source/WebCore/html/ColorInputType.h:61
>      virtual void didChooseColor(const Color&);
> -    virtual bool isColorInputType() const;
> +    virtual void didCleanup();

nit: We had better add OVERRIDE.

> LayoutTests/fast/forms/color/input-color-onchange-event.html:29
> +eventSender.mouseMoveTo(10, 10);
> +eventSender.mouseDown();
> +eventSender.mouseUp();

We had better show a manual testing instruction if there is no eventSender.