[webkit-reviews] review granted: [Bug 71647] DFG operationCreateThis slow path may get the wrong callee in case of inlining : [Attachment 113820] the patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 71647: DFG operationCreateThis slow path may get the wrong callee in case
of inlining
https://bugs.webkit.org/show_bug.cgi?id=71647

Attachment 113820: the patch
https://bugs.webkit.org/attachment.cgi?id=113820&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=113820&action=review


>> Source/JavaScriptCore/dfg/DFGOperations.h:67
>> +typedef JSCell* DFG_OPERATION (*C_DFGOperation_ECC)(ExecState*, JSCell*,
JSCell*);
> 
> DFG_OPERATION is incorrectly named. Don't use underscores in your identifier
names.	[readability/naming] [4]

We really should beat the stylebot into not producing these warnings