[webkit-reviews] review granted: [Bug 71641] InputType::fallbackValue and defaultValue should be const : [Attachment 113809] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 71641: InputType::fallbackValue and defaultValue should be const
https://bugs.webkit.org/show_bug.cgi?id=71641

Attachment 113809: Patch
https://bugs.webkit.org/attachment.cgi?id=113809&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=113809&action=review


> Source/WebCore/html/BaseCheckableInputType.h:51
> +    virtual String fallbackValue() const;

We had better add 'OVERRIDE' too.

> Source/WebCore/html/ColorInputType.h:51
> +    virtual String fallbackValue() const;

ditto.

> Source/WebCore/html/RangeInputType.h:70
> +    virtual String fallbackValue() const;

ditto.

> Source/WebCore/html/ResetInputType.h:47
> +    virtual String defaultValue() const;

ditto.

> Source/WebCore/html/SubmitInputType.h:49
> +    virtual String defaultValue() const;

ditto.