[webkit-reviews] review requested: [Bug 71611] [GTK] simplify ResourceHandleSoup : [Attachment 113786] updated - Remove lots of code that is now unnecessary

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Nov 6 10:01:07 PST 2011


Dan Winship <danw at gnome.org> has asked	for review:
Bug 71611: [GTK] simplify ResourceHandleSoup
https://bugs.webkit.org/show_bug.cgi?id=71611

Attachment 113786: updated - Remove lots of code that is now unnecessary
https://bugs.webkit.org/attachment.cgi?id=113786&action=review

------- Additional Comments from Dan Winship <danw at gnome.org>
ok, moved the sniffing override check to ResourceResponseSoup.cpp. I changed
the existing references to "sniffedContentType()" to "m_sniffedContentType",
which seemed more consistent with the surrounding code.

> I'm sad to see the soup dependency go up again

yeah... based on historical precedent, it seems likely it will get bumped again
during/after the hackfest, so maybe there's an argument for not committing this
until then?


More information about the webkit-reviews mailing list