[webkit-reviews] review requested: [Bug 71625] Web Inspector: Preserve an indentation level when inserting a new line : [Attachment 113782] First try
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Nov 6 04:32:24 PST 2011
Nikita Vasilyev <me at elv1s.ru> has asked for review:
Bug 71625: Web Inspector: Preserve an indentation level when inserting a new
line
https://bugs.webkit.org/show_bug.cgi?id=71625
Attachment 113782: First try
https://bugs.webkit.org/attachment.cgi?id=113782&action=review
------- Additional Comments from Nikita Vasilyev <me at elv1s.ru>
Discussion has been started in https://bugs.webkit.org/show_bug.cgi?id=69986#c6
As you can see on 50th second of http://www.screenr.com/PZZs it doesn't yet
work for:
if (obj.y)
return 42
I think it requires some static analyses that could be done some day.
Source/WebCore/inspector/front-end/TextViewer.js:
- if (handler && handler.call(this)) {
+ if (handler && handler()) {
All handlers are bound, no need for "call" here.
More information about the webkit-reviews
mailing list