[webkit-reviews] review granted: [Bug 71597] Reduce the number of putWithAttributes : [Attachment 113736] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Nov 4 17:16:45 PDT 2011
Adam Roben (:aroben) <aroben at apple.com> has granted Sam Weinig
<sam at webkit.org>'s request for review:
Bug 71597: Reduce the number of putWithAttributes
https://bugs.webkit.org/show_bug.cgi?id=71597
Attachment 113736: Patch
https://bugs.webkit.org/attachment.cgi?id=113736&action=review
------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=113736&action=review
Wait for the EWS bots so you don't break everyone else.
> Source/JavaScriptCore/ChangeLog:19
> + Remove four unused JSObject::putWithAttributes overloads and remove
make
> + one of the remain two overloads not virtual, since no one overloads
it.
Typo: "remove make one of the remain two"
Typo: overloads should be overrides
More information about the webkit-reviews
mailing list