[webkit-reviews] review denied: [Bug 13897] Dragging a file onto <input type="file"> should give distinct visual feedback : [Attachment 113733] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has denied Jon Lee <jonlee at apple.com>'s request for review:
Bug 13897: Dragging a file onto <input type="file"> should give distinct visual
feedback
https://bugs.webkit.org/show_bug.cgi?id=13897

Attachment 113733: Patch
https://bugs.webkit.org/attachment.cgi?id=113733&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=113733&action=review


r- because of the potential stale pointer issue. Other than that I think the
patch is okay!

> Source/WebCore/page/DragController.h:121
> +	   HTMLInputElement* m_fileInputElementUnderMouse;

I am not convinced that using a raw pointer here is safe. For example, it seems
like a script could remove the element from the document while the user is
dragging.