[webkit-reviews] review granted: [Bug 62284] IndexedDB: implement compound (array) key support : [Attachment 113727] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Joshua Bell <jsbell at chromium.org>'s
request for review:
Bug 62284: IndexedDB: implement compound (array) key support
https://bugs.webkit.org/show_bug.cgi?id=62284

Attachment 113727: Patch
https://bugs.webkit.org/attachment.cgi?id=113727&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=113727&action=review


> LayoutTests/storage/indexeddb/key-type-array.html:207
> +    evalAndExpectException("indexedDB.cmp(makeArrayOfDepth(100000), 0)",
"IDBDatabaseException.DATA_ERR");

You may want to double check that this runs quickly in debug, but I think
you'll be fine (looks like in release it's only like 50ms or so to create the
structure).