[webkit-reviews] review granted: [Bug 71588] When CSP blocks mixed content, we shouldn't also warn about mixed content : [Attachment 113711] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 4 14:23:02 PDT 2011


Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 71588: When CSP blocks mixed content, we shouldn't also warn about mixed
content
https://bugs.webkit.org/show_bug.cgi?id=71588

Attachment 113711: Patch
https://bugs.webkit.org/attachment.cgi?id=113711&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=113711&action=review


LGTM.

> Source/WebCore/loader/cache/CachedResourceLoader.cpp:306
>      switch (type) {

This switch really should be a helper function.  Another patch, of course.


More information about the webkit-reviews mailing list