[webkit-reviews] review denied: [Bug 71546] [Qt] Remove ENABLE_SQLITE from qmake files : [Attachment 113635] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Nov 4 12:21:07 PDT 2011
Simon Hausmann <hausmann at webkit.org> has denied Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 71546: [Qt] Remove ENABLE_SQLITE from qmake files
https://bugs.webkit.org/show_bug.cgi?id=71546
Attachment 113635: Patch
https://bugs.webkit.org/attachment.cgi?id=113635&action=review
------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
Thanks! I think the patch is correct in principle, but it doesn't compile like
that anymore :(. We did a bunch of changes in the build system today that will
require this change to adjusted to the new locations.
So take the r- like this: Correct patch, but needs adaption against new
.pri/.pro files before landing :)
More information about the webkit-reviews
mailing list