[webkit-reviews] review granted: [Bug 19079] Send the submissions character encoding in hidden _charset_ field : [Attachment 113692] Updated patch as per review comments

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Vineet Chaudhary (vineetc)
<rgf748 at motorola.com>'s request for review:
Bug 19079: Send the submissions character encoding in hidden _charset_ field
https://bugs.webkit.org/show_bug.cgi?id=19079

Attachment 113692: Updated patch as per review comments
https://bugs.webkit.org/attachment.cgi?id=113692&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=113692&action=review


> Source/WebCore/html/HiddenInputType.h:38
> +class FormDataList;

This forward declaration is not needed. Not sure why you added it.

> Source/WebCore/html/HiddenInputType.h:55
> +    virtual bool appendFormData(FormDataList& encoding, bool
isMultipartForm) const;

Here in the header, the argument name "encoding" is neither helpful nor
desirable. Please omit it.