[webkit-reviews] review denied: [Bug 71535] Add the ability to transfer ArrayBuffer and "neuter" it : [Attachment 113689] CR feedback and tests fixed

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Dmitry Lomov <dslomov at google.com>'s
request for review:
Bug 71535: Add the ability to transfer ArrayBuffer and "neuter" it
https://bugs.webkit.org/show_bug.cgi?id=71535

Attachment 113689: CR feedback and tests fixed
https://bugs.webkit.org/attachment.cgi?id=113689&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=113689&action=review


> Source/WebCore/html/canvas/ArrayBuffer.cpp:132
> +	 ArrayBufferView* current = m_firstView;

4 spaces

> Source/WebCore/html/canvas/ArrayBuffer.h:65
> +	   m_sizeInBytes = 0; 

This isn't really a swap.

       void* otherData = other.m_data;
       unsigned otherSizeInBytes = other.m_sizeInBytes;
       other.m_data = m_data;
       other.m_sizeInBytes = m_sizeInBytes;
       m_data = otherData; 
       m_sizeInBytes = otherSizeInBytes;