[webkit-reviews] review denied: [Bug 71539] [Mac] ResourceRequest's nsURLRequest() does not differentiate null and empty URLs with CFNetwork : [Attachment 113622] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has denied Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 71539: [Mac] ResourceRequest's nsURLRequest() does not differentiate null
and empty URLs with CFNetwork
https://bugs.webkit.org/show_bug.cgi?id=71539

Attachment 113622: Patch
https://bugs.webkit.org/attachment.cgi?id=113622&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=113622&action=review


r=me, but setting the r- flag since you wanted this to go through the commit
queue.	(Also, it seems the win EWS bot is building for Mac OS X?!)

> Source/WebCore/platform/cf/KURLCFNet.cpp:82
> +    CharBuffer buffer;

I don't think you can use CharBuffer here, can you?  It only seems to be
typedef-ed in KURL.cpp.

Might be useful to move that typedef to KURL.h in another patch, though.

> Source/WebCore/platform/mac/KURLMac.mm:75
> +	   return (CFURLRef)[[NSURL alloc] initWithString:@""];

Can you use reinterpret_cast<CFURLRef>() instead of a C-style cast here?