[webkit-reviews] review granted: [Bug 71532] "use strict" can not contain escape sequences or line continuation : [Attachment 113607] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ariya Hidayat
<ariya.hidayat at gmail.com>'s request for review:
Bug 71532: "use strict" can not contain escape sequences or line continuation
https://bugs.webkit.org/show_bug.cgi?id=71532

Attachment 113607: patch
https://bugs.webkit.org/attachment.cgi?id=113607&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=113607&action=review


> Source/JavaScriptCore/parser/Parser.cpp:144
> +		   if (!hasSetStrict && directiveLiteralLength == 12 &&
m_globalData->propertyNames->useStrictIdentifier == *directive) {

This hardcoded 12 is not good. Can we put a named constant at the start of the
file?

> Source/JavaScriptCore/parser/Parser.cpp:653
> +template <class TreeBuilder> TreeStatement
Parser::parseStatement(TreeBuilder& context, const Identifier*& directive,
unsigned *directiveLiteralLength)

misplaced * here