[webkit-reviews] review denied: [Bug 66837] Parse reftest.list and extract types of ref tests : [Attachment 113661] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has denied Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 66837: Parse reftest.list and extract types of ref tests
https://bugs.webkit.org/show_bug.cgi?id=66837

Attachment 113661: Patch
https://bugs.webkit.org/attachment.cgi?id=113661&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=113661&action=review


You should parse the reftest.list files during the initial walk of the
LayoutTests directory. That will reduce a lot of processing and minimize disk
access. I don't think it will make the code more complicated.

> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:340
> +	   self._reftest_list = {}

This isn't a list. Just call it self._reftests.

> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:361
> +	       expectation_type, test_file, ref_file = split_line[0],
split_line[1], split_line[2]

I believe this can just be:
expectation_type, test_file, ref_file = split_line