[webkit-reviews] review denied: [Bug 70484] [WK2] Enable pixel test on WK2 if expected.png exists : [Attachment 112825] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Fehér Zsolt
<feherzs at inf.u-szeged.hu>'s request for review:
Bug 70484: [WK2] Enable pixel test on WK2 if expected.png exists
https://bugs.webkit.org/show_bug.cgi?id=70484

Attachment 112825: Patch
https://bugs.webkit.org/attachment.cgi?id=112825&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112825&action=review


Can you write some python unit tests for this flag?

> Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:113
> +	   if self._port.driver_name() == "WebKitTestRunner" and
self._port.get_option('skip_pixel_test_if_no_baseline') and
self._port.get_option('pixel_tests'):

Can you use self._options.skip_pixel_test_if_no_baseline and
self._options.pixel_tests instead?

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:86
> +	   if options.skip_pixel_test_if_no_baseline and not
(port.driver_name() == "WebKitTestRunner"):

Nit: != seems a little clearer than not (...)