[webkit-reviews] review granted: [Bug 71053] Anonymous CORS fetch for WebGL texture fails when there is no appropriate server response even for the same origin requests : [Attachment 113599] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 71053: Anonymous CORS fetch for WebGL texture fails when there is no
appropriate server response even for the same origin requests
https://bugs.webkit.org/show_bug.cgi?id=71053

Attachment 113599: Patch
https://bugs.webkit.org/attachment.cgi?id=113599&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=113599&action=review


> Source/WebCore/loader/ImageLoader.cpp:246
> +    if (m_element->fastHasAttribute(HTMLNames::crossoriginAttr)
> +	   &&
!m_element->document()->securityOrigin()->canRequest(image()->response().url())

> +	   &&
!resource->passesAccessControlCheck(m_element->document()->securityOrigin())) {


Maybe this can be factored into an inline member function so the if statement
is easier to read. The name of that function could help document what is going
on, too.