[webkit-reviews] review granted: [Bug 66505] Implement allow-popups for iframe at sandbox : [Attachment 113593] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 66505: Implement allow-popups for iframe at sandbox
https://bugs.webkit.org/show_bug.cgi?id=66505

Attachment 113593: Patch
https://bugs.webkit.org/attachment.cgi?id=113593&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This looks OK, but I’m not sure we have enough test coverage. You mention
problems with the previous patch and I am having a little trouble seeing the
tests that were failing because of those problems, or the new tests that
demonstrate them. Maybe it’s just these three tests you are changing here, and
I couldn’t connect the dots.