[webkit-reviews] review granted: [Bug 70765] Default <select multiple> expands up to 10 items instead of showing 4 : [Attachment 113633] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Antaryami Pandia
<xqb748 at motorola.com>'s request for review:
Bug 70765: Default <select multiple> expands up to 10 items instead of showing
4
https://bugs.webkit.org/show_bug.cgi?id=70765

Attachment 113633: Patch
https://bugs.webkit.org/attachment.cgi?id=113633&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=113633&action=review


> LayoutTests/fast/forms/select-clientheight-with-multiple-attr-expected.txt:6
> +PASS clientHeight('sel2') is clientHeight('sel1')
> +PASS getElemById('sel2').setAttribute('size', '5'); clientHeight('sel2') >
clientHeight('sel1') is true
> +PASS clientHeight('sel3') is clientHeight('sel1')
> +PASS getElemById('sel3').setAttribute('size', '2'); clientHeight('sel3') is
clientHeight('sel1')

Good approach on this test now.

I think we should test more than just the fact that the height is larger when
there are more items. We can compare to an exact multiple, and I think it would
work fine on all platforms.

And, I think we should test a *lot* more than these two cases. We want to cover
all the edge cases. Really giant sizes, really small sizes, missing size
attribute, specified size attribute, size attribute that is a number but has
garbage digits after it, size attribute that is the empty string.