[webkit-reviews] review denied: [Bug 71055] Add methods to compute magnitude and phase response for biquads : [Attachment 113591] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Raymond Toy <rtoy at chromium.org>'s
request for review:
Bug 71055: Add methods to compute magnitude and phase response for biquads
https://bugs.webkit.org/show_bug.cgi?id=71055

Attachment 113591: Patch
https://bugs.webkit.org/attachment.cgi?id=113591&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=113591&action=review


Code looks good to me overall. r- for const issues.

> Source/WebCore/platform/audio/Biquad.h:77
> +				 float* frequency,

Because frequency is only an input it should be const float*. This will improve
understandability of the code. This change is needed in a few places.

> Source/WebCore/webaudio/BiquadDSPKernel.h:51
> +    virtual void getFrequencyResponse(int nFrequencies, float* frequencyHz,

frequencyHz should be const float* per comment in Biquad.h. Also, does this
really need to be virtual?

> Source/WebCore/webaudio/BiquadProcessor.h:65
> +    void getFrequencyResponse(int nFrequencies, float* frequencyHz, float*
magResponse, float* phaseResponse);

frequencyHz should be const float*.