[webkit-reviews] review granted: [Bug 70707] CSS Aspect Ratio Property Parsing Stage : [Attachment 113585] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Fady Samuel <fsamuel at chromium.org>'s
request for review:
Bug 70707: CSS Aspect Ratio Property Parsing Stage
https://bugs.webkit.org/show_bug.cgi?id=70707

Attachment 113585: Patch
https://bugs.webkit.org/attachment.cgi?id=113585&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=113585&action=review


Yay!

> Source/WebCore/css/CSSParser.cpp:5679
> +    addProperty(CSSPropertyWebkitAspectRatio, aspectRatioValue.release(),
important);

CSSAspectRatioValue::create returns a PassRefPtr, so you could make this a
one-liner:
addProperty(CSSPropertyWebkitAspectRatio,
CSSAspectRatioValue::create(lvalue->fValue, rvalue->fValue), important);

I guess that's a bit unwieldy. Up to you.