[webkit-reviews] review denied: [Bug 69750] NRWT should handle duplicated expectations : [Attachment 113305] proposed fix

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has denied Kristóf Kosztyó
<kkristof at inf.u-szeged.hu>'s request for review:
Bug 69750: NRWT should handle duplicated expectations
https://bugs.webkit.org/show_bug.cgi?id=69750

Attachment 113305: proposed fix
https://bugs.webkit.org/attachment.cgi?id=113305&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
This is definitely getting closer ...

View in context: https://bugs.webkit.org/attachment.cgi?id=113305&action=review


> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:703
> +	   self._add_skipped_tests(port.skipped_tests())

Can't we just use port.skipped_layout_tests() here and not have to add a
separate function?

> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:836
> +		   _log.warn('The %s test from test_expectations.txt in line %d
is also in Skipped!' %

As per earlier discussion, I think this should probably be an error, not a
warning.

Also, can you add some unit tests to the test_expectations_unittest.py class?