[webkit-reviews] review granted: [Bug 71522] JSC should be able to sample itself in a more flexible way than just sampling flags : [Attachment 113586] the patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 71522: JSC should be able to sample itself in a more flexible way than just
sampling flags
https://bugs.webkit.org/show_bug.cgi?id=71522

Attachment 113586: the patch
https://bugs.webkit.org/attachment.cgi?id=113586&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
One would hope that the SamplingRegion constructors would compile out to no
code when the tool isn't enabled, I'm slightly concerned that C compilers might
disappoint us yet again and we may need to hide these behind a macro.  But if
this isn't showing a regression right now then we can cross this bridge when we
come to it.  Please make the style bot happy.