[webkit-reviews] review denied: [Bug 71502] [chromium] Test for GL_EXT_bgra in addition to GL_EXT_texture_format_BGRA8888/GL_EXT_read_format_bgra for accelerated paining : [Attachment 113577] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Antoine Labour
<piman at chromium.org>'s request for review:
Bug 71502: [chromium] Test for GL_EXT_bgra in addition to
GL_EXT_texture_format_BGRA8888/GL_EXT_read_format_bgra for accelerated paining
https://bugs.webkit.org/show_bug.cgi?id=71502

Attachment 113577: Patch
https://bugs.webkit.org/attachment.cgi?id=113577&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
GraphicsContext3D and Extensions3D have followed the functionality and naming
conventions in OpenGL ES 2.0 and extensions. The most consistent way to handle
this would be to have the underlying implementation report support for
GL_EXT_texture_format_BGRA8888 when running on desktop GL supporting
GL_EXT_bgra. This is how Chromium's command buffer implementation works. See
src/gpu/command_buffer/service/feature_info.cc. For this reason I'm marking
this r-. If you really want to pursue this direction then minimally you need to
update the documentation on Extensions3D.h indicating which extensions it
supports.