[webkit-reviews] review denied: [Bug 68859] ASSERT(!m_styleSheets->length()) can be easily hit when playing with document.open : [Attachment 110024] Tweaked the ASSERT to not trigger in this case as it is too fragile. Added a comment about the fix.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 3 15:14:16 PDT 2011


Julien Chaffraix <jchaffraix at webkit.org> has denied Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 68859: ASSERT(!m_styleSheets->length()) can be easily hit when playing with
document.open
https://bugs.webkit.org/show_bug.cgi?id=68859

Attachment 110024: Tweaked the ASSERT to not trigger in this case as it is too
fragile. Added a comment about the fix.
https://bugs.webkit.org/attachment.cgi?id=110024&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
Looking again at the patch, I thought it was blocking some testing for the
associated crasher but it's possible to work around the ASSERT by enabling the
test only in Release.
Under this light, the patch is not not a good change as we lose coverage for a
potentially bad situation. I will just progress with the other bug and use this
one for the ASSERT failure.


More information about the webkit-reviews mailing list