[webkit-reviews] review denied: [Bug 70407] [TexMap][QT] PageClientQt should skip redundant sync requests during Accelerated Composition. : [Attachment 111585] patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Hwang
<luxtella at company100.net>'s request for review:
Bug 70407: [TexMap][QT] PageClientQt should skip redundant sync requests during
Accelerated Composition.
https://bugs.webkit.org/show_bug.cgi?id=70407

Attachment 111585: patch
https://bugs.webkit.org/attachment.cgi?id=111585&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=111585&action=review


I don't understand the problem, and the patch is either way incorrect.
syncLayers should turn the shoulsSync flag off, as by that point we have
already synced. There might be an issue with animations, in that case setting
the flag should only occur inside the if loop in line 254.

> Source/WebKit/qt/ChangeLog:8
> +	   PageClientQt should receives the sync request after actual TexMap
drawing.

This sentence does not make sense in English.