[webkit-reviews] review denied: [Bug 71456] [PATCH] Move duplicates of SYMBOL_STRING* macros to the single location : [Attachment 113454] webkit-bug-71456-symbol-string.patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has denied Priit Laes (IRC: plaes)
<plaes at plaes.org>'s request for review:
Bug 71456: [PATCH] Move duplicates of SYMBOL_STRING* macros to the single
location
https://bugs.webkit.org/show_bug.cgi?id=71456

Attachment 113454: webkit-bug-71456-symbol-string.patch
https://bugs.webkit.org/attachment.cgi?id=113454&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
I have a local change to carve out of a big patch that would do something
similar to this, so agree in principal, and would be happy to see something
like this land - but I'm not sure that Platform.h is really the right place for
things like this to go.

After discussing with Sam, I was going to add a new wtf/InlineASM.h file for
helper macros like this, but am open to better suggestions.  I'm going to clear
r- for now, so that no-one is too trigger happy on the r+ while we discuss
this.