[webkit-reviews] review granted: [Bug 71313] IndexedDB: Object stores not persisting between sessions : [Attachment 113227] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Joshua Bell <jsbell at chromium.org>'s
request for review:
Bug 71313: IndexedDB: Object stores not persisting between sessions
https://bugs.webkit.org/show_bug.cgi?id=71313

Attachment 113227: Patch
https://bugs.webkit.org/attachment.cgi?id=113227&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
OK, but some things to investigate.

(In reply to comment #7)
> (In reply to comment #6)
> > Created an attachment (id=113235) [details] [details]
> > persistence layout test (doesn't detect bug)
> > 
> > Logically, the attached layout test should work, but it doesn't detect the
bug. The IDBDatabaseBackendImpl is apparently persisting in the
IDBFactoryBackendImpl's m_databaseBackendMap across the page load. If there's a
way to clear out the script execution context, we can try that. Suggestions
welcome.
> 
> You could redirect through another security origin, but that would require an
http test (localhost -> 127.0.0.01 -> localhost)

Does it work to navigate to a different file:/// URL and back?

> > We should investigate why the impl isn't being torn down as promptly as
expected.
> 
> I also wonder whether it's possible to invoke open() or createObjectStore()
after calling close on the IDBDatabase

You should also feel free to add methods to layoutTestController to enable more
testing.