[webkit-reviews] review denied: [Bug 60161] [Qt] Virtual Keyboard is not hidden when you 'unfocus' from input field / QGraphicsWebview : [Attachment 113505] ChangeLog-updated "Close SIP explicitly when IM is disabled" patch.

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Bruno Abinader
<bruno.de_oliveira at basyskom.de>'s request for review:
Bug 60161: [Qt] Virtual Keyboard is not hidden when you 'unfocus' from input
field / QGraphicsWebview
https://bugs.webkit.org/show_bug.cgi?id=60161

Attachment 113505: ChangeLog-updated "Close SIP explicitly when IM is disabled"
patch.
https://bugs.webkit.org/attachment.cgi?id=113505&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
r-

As just discussed on IRC, the CSIP event should not be necessary to send, as
the input context should hide the vkb when the input method attribute/flag gets
disabled.

Alternatively if that's unfixible on the input method side, the CSIP event
should be sent where we disable the flag.

The ChangeLog also says OOPS and the sipRequested variable is unused :)