[webkit-reviews] review denied: [Bug 71458] [chromium] MediaStream API: Add WebMediaStreamRegistry : [Attachment 113467] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Tommy Widenflycht
<tommyw at google.com>'s request for review:
Bug 71458: [chromium] MediaStream API: Add WebMediaStreamRegistry
https://bugs.webkit.org/show_bug.cgi?id=71458

Attachment 113467: Patch
https://bugs.webkit.org/attachment.cgi?id=113467&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=113467&action=review


> Source/WebKit/chromium/public/WebMediaStreamRegistry.h:36
> +    // Returns an empty string if the url doesn't correspond to a Stream
object.

empty or null?	seems like null (WebString::isNull) is what it actually
returns.

> Source/WebKit/chromium/src/WebMediaStreamRegistry.cpp:44
> +    if (streamDescriptor)

it seems like you should return WebMediaStreamDescriptor here instead. 
WebMediaStreamDescriptor has a label() method.
it creates an API that is a more lightweight wrapper around what WebCore
actually does.