[webkit-reviews] review canceled: [Bug 60161] [Qt] Virtual Keyboard is not hidden when you 'unfocus' from input field / QGraphicsWebview : [Attachment 113501] "Close SIP explicitly when IM is disabled" patch.

[bugzilla-daemon at webkit.org]

Bruno Abinader <bruno.de_oliveira at basyskom.de> has canceled Bruno Abinader
<bruno.de_oliveira at basyskom.de>'s request for review:
Bug 60161: [Qt] Virtual Keyboard is not hidden when you 'unfocus' from input
field / QGraphicsWebview
https://bugs.webkit.org/show_bug.cgi?id=60161

Attachment 113501: "Close SIP explicitly when IM is disabled" patch.
https://bugs.webkit.org/attachment.cgi?id=113501&action=review

------- Additional Comments from Bruno Abinader <bruno.de_oliveira at basyskom.de>
Deep sorry guys, I made a mistake when sending the attachment. But taking the
opportunity to answering Kenneth's question: Yes, the
QEvent::CloseSoftwareInputPanel event is sent if client->inputMethodEnabled()
returns false. The rationale is that if IM is disabled, then there's no need
anymore to show SIP. I've tested it against the testcase and works as expected.