[webkit-reviews] review requested: [Bug 60161] [Qt] Virtual Keyboard is not hidden when you 'unfocus' from input field / QGraphicsWebview : [Attachment 113501] "Close SIP explicitly when IM is disabled" patch.

[bugzilla-daemon at webkit.org]

Bruno Abinader <bruno.de_oliveira at basyskom.de> has asked  for review:
Bug 60161: [Qt] Virtual Keyboard is not hidden when you 'unfocus' from input
field / QGraphicsWebview
https://bugs.webkit.org/show_bug.cgi?id=60161

Attachment 113501: "Close SIP explicitly when IM is disabled" patch.
https://bugs.webkit.org/attachment.cgi?id=113501&action=review

------- Additional Comments from Bruno Abinader <bruno.de_oliveira at basyskom.de>
This updated patch does not remove any support for QStyle::RSIP_OnMouseClick
(indeed, first click on the input text box focuses it, but only after second
click the VKB appears, same expected behavior). The static bool sipRequested is
just a flag to avoid unnecessary emissions of QEvent::CloseSoftwareInputPanel.
Also, as Kenneth suggested, filterEvent() is used to propagate the event.

ps: While working on this patch, I noticed, for example, that the VKB is still
not closed after you digit anything on Google's text box and click on "Return"
key. This updates the view screen showing the results of Google's query, so
focus is no longer at the text box. I tried adding some logic when the
"loadFinished" signal is emitted from QWebView and it worked, but with some
issues still to resolve. I am going to create another bug entry for this
particular case.