[webkit-reviews] review denied: [Bug 63616] Add missing methods used by fast/notifications tests to LayoutTestController : [Attachment 112682] Patch

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has denied Alexandre Mazari
<scaroo at gmail.com>'s request for review:
Bug 63616: Add missing methods used by fast/notifications tests to
LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=63616

Attachment 112682: Patch
https://bugs.webkit.org/attachment.cgi?id=112682&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=112682&action=review


Please correct me if I'm wrong but checkDesktopNotificationPermission() and
areDesktopNotificationPermissionRequestsIgnored() are not needed at all.

> Tools/DumpRenderTree/LayoutTestController.h:143
>      bool checkDesktopNotificationPermission(JSStringRef origin);

This doesn't seem to be used by any test. Might be worth just removing it all
together from the LayoutTestController.

> Tools/DumpRenderTree/LayoutTestController.h:145
> +    bool areDesktopNotificationPermissionRequestsIgnored();

This doesn't seem to be used by any LayoutTest. Why adding it?