[webkit-reviews] review denied: [Bug 71357] Web Inspector: Cannot edit elements commented with <!-- : [Attachment 113471] [PATCH] Suggested solution
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 3 06:57:49 PDT 2011
Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 71357: Web Inspector: Cannot edit elements commented with <!--
https://bugs.webkit.org/show_bug.cgi?id=71357
Attachment 113471: [PATCH] Suggested solution
https://bugs.webkit.org/attachment.cgi?id=113471&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=113471&action=review
r- for two branches in setOuterHTML
> LayoutTests/inspector/elements/edit-dom-actions.html:165
> + if (typeof dataNode === "string")
You should use different method for comment nodes.
> Source/WebCore/inspector/InspectorDOMAgent.cpp:772
> + RefPtr<DocumentFragment> fragment =
DocumentFragment::create(document);
You should use this branch for both cases.
> Source/WebCore/inspector/InspectorDOMAgent.cpp:776
> + return;
Assign errorString here.
> Source/WebCore/inspector/InspectorDOMAgent.cpp:781
> + return;
ditto
> Source/WebCore/inspector/InspectorDOMAgent.cpp:791
> + if (ec)
ditto
> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:1061
> + _populateCommentContextMenu: function(contextMenu, commentNode)
You should call this method from _populateTagContextMenu (and call it
_populateNodeContextMenu). Should also work for Text nodes.
More information about the webkit-reviews
mailing list