[webkit-reviews] review requested: [Bug 66851] Fix CSSPrimitiveValue::cssText() to use StringBuilder : [Attachment 113473] Correcting

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 3 06:20:47 PDT 2011


Oliver Varga <voliver at inf.u-szeged.hu> has asked  for review:
Bug 66851: Fix CSSPrimitiveValue::cssText() to use StringBuilder
https://bugs.webkit.org/show_bug.cgi?id=66851

Attachment 113473: Correcting
https://bugs.webkit.org/attachment.cgi?id=113473&action=review

------- Additional Comments from Oliver Varga <voliver at inf.u-szeged.hu>
I made the previous requests:
 * I corrected the indentation, and rename some variables and functions.
The next step, I will do shortly:
 * I am going to create a new cpp and header file what name is
NumericFormatting.h/cpp.
 * It will includes low level numeric formatting functions, that allows higher
level classes like String and StringBuilder to use them
   efficiently, so the StringBuilder::append(double) would call the
NumericFormatting::doubleToAsciiUsedByDtoa.


More information about the webkit-reviews mailing list