[webkit-reviews] review granted: [Bug 71115] IndexedDB: Recycle cursor objects when calling continue() : [Attachment 113325] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Hans Wennborg
<hans at chromium.org>'s request for review:
Bug 71115: IndexedDB: Recycle cursor objects when calling continue()
https://bugs.webkit.org/show_bug.cgi?id=71115

Attachment 113325: Patch
https://bugs.webkit.org/attachment.cgi?id=113325&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=113325&action=review


> Source/WebCore/storage/IDBRequest.cpp:375
> +    RefPtr<IDBCursorWithValue>
cursorWithValue(static_cast<IDBCursorWithValue*>(prpCursor.get()));

I think this would be much nicer if you had a function like this:

  static PassRefPtr<IDBCursorWithValue>
IDBCursorWithValue::fromCursor(PassRefPtr<IDBCursor>)

Then, this callsite would turn into:

  m_result = IDBAny::create(IDBCursorWithValue::fromCursor(prpCursor));

Nice, right?