[webkit-reviews] review granted: [Bug 71427] Inlined uses of the global object should use the right global object : [Attachment 113413] the patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 71427: Inlined uses of the global object should use the right global object
https://bugs.webkit.org/show_bug.cgi?id=71427

Attachment 113413: the patch
https://bugs.webkit.org/attachment.cgi?id=113413&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=113413&action=review


r=me, but i don't believe that fix me is correct.

> Source/JavaScriptCore/dfg/DFGJITCompiler.h:439
> +	   // FIXME: if we ever inline based on executable not function, this
code will need to change.

I don't believe that this is correct -- all functions for a given executable
must by definition share the same global object.