[webkit-reviews] review denied: [Bug 69127] [EFL] Enabling the Page Visibility API : [Attachment 112814] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 2 18:07:35 PDT 2011


Gyuyoung Kim <gyuyoung.kim at samsung.com> has denied Dongwoo Joshua Im
<dw.im at samsung.com>'s request for review:
Bug 69127: [EFL] Enabling the Page Visibility API
https://bugs.webkit.org/show_bug.cgi?id=69127

Attachment 112814: Patch
https://bugs.webkit.org/attachment.cgi?id=112814&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=112814&action=review


> Source/WebKit/efl/ewk/ewk_view.cpp:3880
> +    EWK_VIEW_SD_GET_OR_RETURN(ewkView, sd, EINA_FALSE);

Oops. this patch has a nit. We don't use abbreviation anymore. Change sd with
smartData.


More information about the webkit-reviews mailing list