[webkit-reviews] review granted: [Bug 71267] [chromium] Slow down commit and draw rate based on visibility and draw completion : [Attachment 113375] Without ImmediateState

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Nat Duca
<nduca at chromium.org>'s request for review:
Bug 71267: [chromium] Slow down commit and draw rate based on visibility and
draw completion
https://bugs.webkit.org/show_bug.cgi?id=71267

Attachment 113375: Without ImmediateState
https://bugs.webkit.org/attachment.cgi?id=113375&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=113375&action=review


R=me, one comment for you to think about and do what you think is best.

> Source/WebCore/platform/graphics/chromium/cc/CCScheduler.cpp:102
> +    // Adjust the state machine's visbility state to the proxy's visibility
state
> +    m_stateMachine.setVisible(m_client->visible());

For your consideration: instead of pulling visible state from the client here,
could the client push the visible state down when it changes to the scheduler?
It's a little easier for me to reason about interactions when state tends to
flow in one direction.

> Source/WebCore/platform/graphics/chromium/cc/CCSchedulerStateMachine.h:32
> +// The CCSched decides how to coordinates main thread activites

looks like you accidentally part of this comment