[webkit-reviews] review granted: [Bug 71163] --webkit-visual-word enable it in cr-win by command line flag : [Attachment 113361] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 2 13:45:21 PDT 2011


Ryosuke Niwa <rniwa at webkit.org> has granted Xiaomei Ji <xji at chromium.org>'s
request for review:
Bug 71163: --webkit-visual-word enable it in cr-win by command line flag
https://bugs.webkit.org/show_bug.cgi?id=71163

Attachment 113361: patch
https://bugs.webkit.org/attachment.cgi?id=113361&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=113361&action=review


> Source/WebCore/editing/FrameSelection.cpp:638
> +	   Settings* settings = m_frame ? m_frame->settings() : 0;
> +	   if (settings && settings->visualWordMovementEnabled()) {

Please make this an inline helper function.


More information about the webkit-reviews mailing list