[webkit-reviews] review granted: [Bug 71390] Use m_pluginSize instead of m_frameRectInWindowCoordinates.width in NetscapePlugin : [Attachment 113356] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 2 13:21:19 PDT 2011


Adam Roben (:aroben) <aroben at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 71390: Use m_pluginSize instead of m_frameRectInWindowCoordinates.width in
NetscapePlugin
https://bugs.webkit.org/show_bug.cgi?id=71390

Attachment 113356: Patch
https://bugs.webkit.org/attachment.cgi?id=113356&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=113356&action=review


> Source/WebKit2/ChangeLog:4
> +	   Use m_pluginSize instead of m_frameRectInWindowCoordinates.width in
NetscapePlugin
> +	   https://bugs.webkit.org/show_bug.cgi?id=71390

You also aren't using m_frameRectInWindowCoordinates.height anymore.

I assume m_pluginSize is always equal to m_frameRectInWindowCoordinates.size()
in normal cases. It might be worth mentioning that, and whether there are cases
where they are not equal.


More information about the webkit-reviews mailing list