[webkit-reviews] review denied: [Bug 71374] Remove initCloseEvent method : [Attachment 113338] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has denied Dominic Cooney
<dominicc at chromium.org>'s request for review:
Bug 71374: Remove initCloseEvent method
https://bugs.webkit.org/show_bug.cgi?id=71374

Attachment 113338: Patch
https://bugs.webkit.org/attachment.cgi?id=113338&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=113338&action=review


> Source/WebCore/websockets/CloseEvent.h:63
>      void initCloseEvent(const AtomicString& type, bool canBubble, bool
cancelable, bool wasClean, unsigned short code, const String& reason)

Can we move this into the CloseEvent constructor and get rid of the
canBubble/cancelable arguments since they are always false in the one place
initCloseEvent is currently called? If there's a reason this is especially
complicated, I'm OK with the patch as is and I'll r+ it. For now r-.