[webkit-reviews] review denied: [Bug 70507] [Chromium] Refactor WebFrameImpl::createFrameView() to use Frame:createView : [Attachment 112348] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 2 10:52:31 PDT 2011


Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Fady Samuel
<fsamuel at chromium.org>'s request for review:
Bug 70507: [Chromium] Refactor WebFrameImpl::createFrameView() to use
Frame:createView
https://bugs.webkit.org/show_bug.cgi?id=70507

Attachment 112348: Patch
https://bugs.webkit.org/attachment.cgi?id=112348&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112348&action=review


> Source/WebKit/chromium/src/WebFrameImpl.cpp:-2023
> -    if (webView->isTransparent())

It looks like you are losing this step, which I think matters for chrome
extensions.


More information about the webkit-reviews mailing list