[webkit-reviews] review granted: [Bug 70896] MediaStreamRegistry should hold references to MediaStreamDescriptor rather than MediaStream : [Attachment 113330] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Tommy Widenflycht
<tommyw at google.com>'s request for review:
Bug 70896: MediaStreamRegistry should hold references to MediaStreamDescriptor
rather than MediaStream
https://bugs.webkit.org/show_bug.cgi?id=70896

Attachment 113330: Patch
https://bugs.webkit.org/attachment.cgi?id=113330&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=113330&action=review


> Source/WebCore/ChangeLog:14
> +	   Tests for the Media Stream API will be provided by the bug 56587,
pending enough landed code.

Usually we put this information above the list of files/function names.

> Source/WebCore/mediastream/MediaStreamRegistry.cpp:46
> -    m_streams.add(url.string(), stream);
> +    m_streamDescriptors.set(url.string(), stream->descriptor());

You wrote "fixed", but this doesn't appear to have changed.  :)